Skip to content

Remove extra comma in println! statement#758

Merged
samueltardieu merged 1 commit intomainfrom
push-owvomnoonkqn
Mar 10, 2026
Merged

Remove extra comma in println! statement#758
samueltardieu merged 1 commit intomainfrom
push-owvomnoonkqn

Conversation

@samueltardieu
Copy link
Copy Markdown
Member

@samueltardieu samueltardieu commented Mar 10, 2026 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • Style
    • Minor code formatting cleanup in example files.

@samueltardieu samueltardieu enabled auto-merge March 10, 2026 08:51
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 10, 2026 •
edited
Loading

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: e69d4f1b-3d1f-4308-9b15-75b2e4c83260

📥 Commits

Reviewing files that changed from the base of the PR and between b898eee and 4cfa563.

📒 Files selected for processing (1)
  • examples/sliding-puzzle.rs
📝 Walkthrough

Walkthrough

Removed trailing commas from two println! macro invocations in the sliding puzzle example, correcting invalid Rust syntax that would prevent successful compilation.

Changes

Cohort / File(s) Summary
Syntax Cleanup
examples/sliding-puzzle.rs		 Removed trailing commas from println! statements for idastar and astar result printing.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~1 minute

Poem

🐰 A trailing comma, oh what a fright!
Two little fix-ups, now syntax is right.
Sliding and solving, the puzzle runs clean,
The smoothest example I've ever seen! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and accurately describes the main change: removing trailing commas from two println! statements in the code.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch push-owvomnoonkqn

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@samueltardieu samueltardieu added this pull request to the merge queue Mar 10, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 10, 2026

📊 iai-callgrind Benchmark Results

➡️ 20 Unchanged (within ±0.1%)

Click to expand
Benchmark Instructions
iai_algos::corner_to_corner_astar 150,136
iai_algos::corner_to_corner_bfs 2,947,648
iai_algos::corner_to_corner_bfs_bidirectional 3,881,580
iai_algos::corner_to_corner_dfs 3,592,021
iai_algos::corner_to_corner_dijkstra 3,734,617
iai_algos::corner_to_corner_fringe 216,701
iai_algos::corner_to_corner_idastar 194,543
iai_algos::corner_to_corner_iddfs 3,718,131
iai_algos::no_path_astar 3,348,856
iai_algos::no_path_bfs 2,756,526
iai_algos::no_path_bfs_bidirectional 3,383,731
iai_algos::no_path_dfs 3,629,686
iai_algos::no_path_dijkstra 3,691,818
iai_algos::no_path_fringe 4,417,030
iai_edmondskarp::wikipedia_example_dense 38,324
iai_edmondskarp::wikipedia_example_sparse 65,772
iai_kuhn_munkres::kuhn_munkres_size_128 4,965,503
iai_kuhn_munkres::kuhn_munkres_size_32 303,986
iai_kuhn_munkres::kuhn_munkres_size_64 1,434,909
iai_separate_components::bench_separate_components 16,016,716

✅ All benchmarks unchanged

iai-callgrind measures instructions executed, which is deterministic and not affected by system load.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Mar 10, 2026

Merging this PR will degrade performance by 19.62%

❌ 6 regressed benchmarks
✅ 32 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Benchmark BASE HEAD Efficiency
❌ no_path_astar 1.5 ms 1.8 ms -13.5%
❌ Compare kuhn_munkres with different input sizes[256] 19 ms 22.8 ms -16.83%
❌ Compare kuhn_munkres with different input sizes[128] 1.6 ms 2 ms -19.62%
❌ Compare kuhn_munkres with different input sizes[32] 108.3 µs 125.8 µs -13.88%
❌ Compare kuhn_munkres with different input sizes[64] 483.7 µs 581 µs -16.74%
❌ Compare kuhn_munkres with different input sizes[512] 454.2 ms 533.1 ms -14.8%

Comparing push-owvomnoonkqn (4cfa563) with main (b898eee)

Open in CodSpeed

Merged via the queue into main with commit 3761d48 Mar 10, 2026
15 checks passed
@samueltardieu samueltardieu deleted the push-owvomnoonkqn branch March 10, 2026 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@samueltardieu